Skip to content

perf: speed up benchmark checkout - #23211

Merged
arnaud-lb merged 1 commit into
php:PHP-8.2from
NickSdot:perf/benchmark-downloads
Aug 11, 2026
Merged

perf: speed up benchmark checkout#23211
arnaud-lb merged 1 commit into
php:PHP-8.2from
NickSdot:perf/benchmark-downloads

Conversation

@NickSdot

Copy link
Copy Markdown
Contributor

No brainer extracted from #22995. Targeting 8.2.

cc: @iluuu1994 @arnaud-lb

@arnaud-lb

Copy link
Copy Markdown
Member

I'm wondering if that's actually faster. Locally, a git clone https://github.com/php/php-src --filter=blob:none --depth=1 takes twice the time vs no filter.

@iluuu1994

Copy link
Copy Markdown
Member

But what about no depth? That's what the job does, because we need to inspect the history but not the files.

@NickSdot

Copy link
Copy Markdown
Contributor Author

I'm wondering if that's actually faster. Locally, a git clone https://github.com/php/php-src --filter=blob:none --depth=1 takes twice the time vs no filter.

With your --depth=1 is not the same. With it barely any historical blobs have to be filtered/skipped.

But what about no depth? That's what the job does, because we need to inspect the history but not the files.

Exactly. Without --depth=1 the blob:none does not fetch all old file contents but keeps the full commit history, which is what it needs here. My local tests are ~3× faster.

@arnaud-lb

arnaud-lb commented Aug 11, 2026

Copy link
Copy Markdown
Member

Ok, I got confused by fetch-depth: 0. I confirm that --filter=blob:none without --depth 1 is faster.

@arnaud-lb
arnaud-lb merged commit 8a90e02 into php:PHP-8.2 Aug 11, 2026
18 checks passed
arnaud-lb added a commit that referenced this pull request Aug 11, 2026
* PHP-8.5:
  perf: speed up benchmark checkout (#23211)
@arnaud-lb

Copy link
Copy Markdown
Member

Thank you!

@NickSdot
NickSdot deleted the perf/benchmark-downloads branch August 11, 2026 09:57
pull Bot pushed a commit to dolfly/php-src that referenced this pull request Aug 11, 2026
* PHP-8.2:
  perf: speed up benchmark checkout (php#23211)
pull Bot pushed a commit to dolfly/php-src that referenced this pull request Aug 11, 2026
* PHP-8.3:
  perf: speed up benchmark checkout (php#23211)
pull Bot pushed a commit to dolfly/php-src that referenced this pull request Aug 11, 2026
* PHP-8.4:
  perf: speed up benchmark checkout (php#23211)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants